Remove duplicate release creation from CI workflow#21
Conversation
The ci.yml workflow was conflicting with the dedicated release.yml workflow, causing permission errors when both tried to create releases on tag pushes. Now release.yml (with GoReleaser) is the sole owner of release creation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
WalkthroughThe CI workflow was updated by removing tag-based triggers and deleting the release creation job that ran on tag references. Push events no longer include tags, and automated GitHub Releases are no longer created. Artifact upload remains with a 7-day retention setting. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer
participant GH as GitHub
participant CI as CI Workflow
Dev->>GH: Push commit (branch)
GH-->>CI: Trigger workflow (push on branch)
Note over CI: Build/Test jobs run<br/>(artifacts retained 7 days)
Dev->>GH: Push tag (vX.Y.Z)
GH--xCI: No trigger (tag push removed)
Note over GH,CI: Release job removed<br/>No GitHub Release created
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
91-95: Unreachable tag branch in version detectionLine 91 still checks for
refs/tags/v*, but CI no longer runs on tag pushes, so this branch will never execute. Simplify to avoid dead code.Apply this diff to streamline the logic:
- if [[ $GITHUB_REF == refs/tags/v* ]]; then - VERSION=${GITHUB_REF#refs/tags/} - else - VERSION=$(git describe --tags --always --dirty) - fi + VERSION=$(git describe --tags --always --dirty)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/ci.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build
- GitHub Check: Build
1 participant
The ci.yml workflow was conflicting with the dedicated release.yml workflow, causing permission errors when both tried to create releases on tag pushes. Now release.yml (with GoReleaser) is the sole owner of release creation.
🤖 Generated with Claude Code
Summary by CodeRabbit